Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update igv.js chrom alias files to include alias for chrom M #4871

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Sep 19, 2024

This PR adds a functionality or fixes a bug.

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. how to test it, possibly with real cases/data

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by DN
  • tests executed by DN

Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0bc179b). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4871   +/-   ##
=======================================
  Coverage        ?   84.77%           
=======================================
  Files           ?      319           
  Lines           ?    19296           
  Branches        ?        0           
=======================================
  Hits            ?    16358           
  Misses          ?     2938           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dnil
Copy link
Collaborator

dnil commented Sep 19, 2024

Now correctly loads data also for contig M alignment data:
Screenshot 2024-09-19 at 09 26 36
The change on hg19 is a little complicated, since there are some different builds in rotation for e.g. 1kg. But we have opted to "solve" that by always starting on hg38 for MT anyway, so should be all good.

Copy link
Collaborator

@dnil dnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@northwestwitch
Copy link
Member Author

Nice, thanks for testing!

@northwestwitch northwestwitch merged commit d2dcb01 into main Sep 19, 2024
26 checks passed
@northwestwitch northwestwitch deleted the new_igv_chrom_aliases branch September 24, 2024 14:27
dreamweaver-cell pushed a commit to gmc-norr/scout that referenced this pull request Oct 9, 2024
dreamweaver-cell pushed a commit to dreamweaver-cell/scout that referenced this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No reads shown for MT variants in internal IGV
2 participants