-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix triple clinvar filter #5006
base: main
Are you sure you want to change the base?
Conversation
LOG.debug("add CLINSIG filter for rank: %s" % ", ".join(str(query["clinsig"]))) | ||
clnsig_query = {"clnsig": {"$elemMatch": elem_match_or}} | ||
|
||
if query.get("clinvar_tag"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix: this filter is removed from the secondary query and set together with the other 2 clinvar-based filters, in the function dedicated to building the clinvar filters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5006 +/- ##
=======================================
Coverage 84.76% 84.76%
=======================================
Files 320 320
Lines 19359 19360 +1
=======================================
+ Hits 16410 16411 +1
Misses 2949 2949 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stage
and the server iscg-vm1
.ssh <USER.NAME>@cg-vm1.scilifelab.se
sudo -iu hiseq.clinical
ssh localhost
podman ps
systemctl --user stop scout.target
systemctl --user start scout@<this_branch>
systemctl --user status scout.target
scout-stage
) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.se
us; paxa -u <user> -s hasta -r scout-stage
. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browser
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
us; scout --version
paxa
procedure, which will release the allocated resource (scout-stage
) to be used for testing by other users.How to test:
Check the difference between this branch and main branch!
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: