Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANE badges to the long list of transcripts on variant page #5009

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Nov 11, 2024

This PR adds a functionality or fixes a bug.

  • Closes MANE for SVs #5004 --> I have reasoned that it is better to add MANE tags down in the transcripts table because a SV variant can have many genes and we don't want the variant page swamped with refseq transcritps, which will happen if we introduce the RefSeq transcripts panel as we have on SNV variant page
Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. Check out this variant from a demo case with build 38, both on main branch and this branch

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by DN
  • tests executed by CR

@northwestwitch northwestwitch changed the title Add MANE transcripts to the long list of transcripts on variant page Add MANE badges to the long list of transcripts on variant page Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.76%. Comparing base (e7a56e8) to head (93dbb90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5009   +/-   ##
=======================================
  Coverage   84.76%   84.76%           
=======================================
  Files         320      320           
  Lines       19351    19353    +2     
=======================================
+ Hits        16402    16405    +3     
+ Misses       2949     2948    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch
Copy link
Member Author

Main branch, where some content is displayed outside the page

image

This branch

image

@northwestwitch northwestwitch marked this pull request as ready for review November 11, 2024 11:48
{% endif %}
</td>
<td>
{{ transcript.refseq_identifiers|join(',') }}
{{ transcript.refseq_identifiers|join(', ') }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the content being displayed outside the page window

Copy link
Collaborator

@dnil dnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Also nice fix for the table!

Next time we add it to a template, we might make a macro, but so far so good. 😁

Copy link

sonarcloud bot commented Nov 12, 2024

@northwestwitch northwestwitch merged commit 5107b99 into main Nov 12, 2024
25 checks passed
@northwestwitch northwestwitch deleted the sv_mane branch November 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MANE for SVs
2 participants