Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename RecordView.enabled to isEnabled #10

Merged
merged 1 commit into from
Apr 2, 2018
Merged

rename RecordView.enabled to isEnabled #10

merged 1 commit into from
Apr 2, 2018

Conversation

DivineDominion
Copy link
Contributor

This is in line with NSControl.isEnabled. Even though RecordView is not inheriting from NSControl, it is a control :) I see no benefit of breaking with Swift's naming convention here and do think it looks odd otherwise:

someView.isEnabled = true
otherView.isEnabled = true
recordView.enabled = true

I have not added deprecations to enabled but will gladly do if you want to not create a breaking API change here.

Econa77
Econa77 approved these changes Apr 2, 2018
View reviewed changes
Copy link
Member

@Econa77 Econa77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DivineDominion Nice catch 👍
I also think that added deprecations is not necessary.

@Econa77 Econa77 merged commit afd4094 into Clipy:master Apr 2, 2018
@DivineDominion DivineDominion deleted the rename-isEnabled branch April 3, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Econa77 Econa77 Econa77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DivineDominion @Econa77