Add #if os(macOS) macro #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I would like to ask if there is anything that needs to be modified in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for developing such a useful library.
I'm working on a SwiftUI-based project that also supports iOS/macOS, and when I'm using Keyholder, everything is perfect, the only problem is that it breaks the preview of the iOS platform and keeps it in an uncompilable state.
After some experimentation, I found that I needed to add the #if os (macOS) macro to the Keyholder and associated Sauce/Magnet to explicitly tell the preview not to import and compile this part of the code on iOS platforms.
SwiftUI and cross-platform apps are becoming more and more common, and preview is a very powerful feature in SwiftUI. So I think this change is necessary.
Thanks!