-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add testing for activerecord 7.1 #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only failing tests are missed cleanup due to dropping MySQL < 5.7.5, everything else looks good
else | ||
WithAdvisoryLock::MySQLNoNesting | ||
end | ||
WithAdvisoryLock::MySQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're dropping support for MySQL versions that don't support shared locks then there's a few more lines to change:
Remove:
raise ArgumentError, 'shared locks are not supported on MySQL' if shared |
Nested is different than shared, let me check again
Edit: ah I understand now, the error gets printed to $stderr because of Thread.report_on_exception
but the error itself is expected
My guess for the Trilogy packet error is that the mysql docker container is configured to use The container may need to be configured to use |
Co-authored-by: Hartley McGuire <skipkayhil@gmail.com>
a416592
to
9b958ec
Compare
Fixed the build . |
Looks great to me, I was able to point my app at this branch and the test suite ran fully (instead of falling back to Thanks for following up so quickly! |
@@ -11,7 +11,7 @@ jobs: | |||
runs-on: ubuntu-latest | |||
services: | |||
mysql: | |||
image: mysql/mysql-server:8.0.30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this downgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mysql 8 uses caching_sha2_password
by default which is currently unsupported by Trilogy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still possible to make trilogy work with mysql 8 by forcing the legacy auth mode.
Dropped support for unsupported rails and ruby version.
I rewrote the test using native syntax to allow easier future upgrade.