simplicicaiton generation of ca, enhance test to ensure stable subject #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 32.17% 32.18%
=======================================
Files 75 75
Lines 9739 9728 -11
=======================================
- Hits 3134 3131 -3
+ Misses 5963 5956 -7
+ Partials 642 641 -1 ☔ View full report in Codecov by Sentry. |
rgooch
approved these changes
Jun 9, 2024
lib/certgen/certgen.go
Outdated
| // of the sha256sum of the rsa signature of the sha256 of the | ||
| // common name. This to have a stable, key dependent | ||
| // serial number. | ||
| // Howeve this was a bad idea as: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.