Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymaster: enable round-robin dialer by default. #91

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

rgooch
Copy link
Member

@rgooch rgooch commented Feb 8, 2021

No description provided.

@rgooch rgooch requested a review from cviecco February 8, 2021 04:48
@rgooch
Copy link
Member Author

rgooch commented May 27, 2024

@cviecco: can we finally merge this?

@cviecco
Copy link
Contributor

cviecco commented May 27, 2024

Can you fix the conflicts? And ensure it works on MacOS and linux?. We can cross our fingers in windows for now.

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.39%. Comparing base (5fd5e96) to head (bf8ffc5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   32.17%   32.39%   +0.21%     
==========================================
  Files          75       75              
  Lines        9739     9739              
==========================================
+ Hits         3134     3155      +21     
+ Misses       5963     5942      -21     
  Partials      642      642              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgooch
Copy link
Member Author

rgooch commented Jun 9, 2024

Can you fix the conflicts? And ensure it works on MacOS and linux?. We can cross our fingers in windows for now.

Conflicts fixed. Tested on Linux. Will test on MacOS when I get to the office.

@rgooch rgooch merged commit a2caeee into Cloud-Foundations:master Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants