Add spec v2 #4
Merged
Add spec v2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergwolf
approved these changes
Sep 29, 2024
| // | ||
| // This structure is designed to be flexible and accommodate various transformer architectures | ||
| // used in state-of-the-art language models. | ||
| type TransformerForCausalLLM struct { |
There was a problem hiding this comment.
This is not referenced anywhere. Let's add it when config.go references it?
| MediaTypeModelConfig = "application/vnd.cnai.model.config.v2+json" | ||
|
|
||
| // MediaTypeModelLicense specifies the media type for model license. | ||
| MediaTypeModelLicense = "application/vnd.cnai.model.license.v2+json" |
There was a problem hiding this comment.
Why is the license file in json format? Looks like plaintext is better.
| const ( | ||
| // MediaTypeModelProcessorText specifies the media type for text processors. | ||
| // This includes tokenizers like sentencepiece, used for processing textual input. | ||
| MediaTypeModelProcessorText = "application/vnd.cnai.model.processor.text.v2.tar" |
There was a problem hiding this comment.
The processors are source code files right? Let's compress it with tar+gzip or tar+zstd?
There was a problem hiding this comment.
ok, I see that zstd is still wip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.