chore: remove ip address scope when checking if an ip address is whitelisted #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derklaro
added
v: 4.X
derklaro
changed the title
0utplay
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At the moment the ip address scope of ipv6 addresses is required to be appended to the a whitelisted address, as the scope is added to the ip by default. While we're already removing the address scopes during the initial setup, we're not removing them when actually checking, leading to the issue that people need to find out and append the scope to addresses in the whitelist.
Modification
Ensure that we strip the scope from addresses in the whitelist (to not break existing setups) and remove the scope from client addresses when checking.
Result
The address scope is no longer taken into account when checking whether a client is allowed to connect to the node.
Other context
Fixes #965