fix: headers in service inclusions should be optional #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
derklaro
reviewed
Apr 11, 2023
| @@ -359,7 +359,7 @@ public void includeWaitingServiceInclusions() { | |||
| // prepare the connection from which we load the inclusion | |||
| var req = Unirest.get(inclusion.url()); | |||
| // put the given http headers | |||
| var headers = inclusion.readProperty(ServiceRemoteInclusion.HEADERS); | |||
| var headers = inclusion.readPropertyOrDefault(ServiceRemoteInclusion.HEADERS, JsonDocument.emptyDocument()); | |||
There was a problem hiding this comment.
Delayed until #1178, this should use Document.emptyDocument() after.
derklaro
approved these changes
Apr 12, 2023
derklaro
pushed a commit
that referenced
this pull request
Apr 17, 2023
### Motivation When including an inclusion that has no headers option set the following exception is thrown. https://cdn.discordapp.com/attachments/818777626663321671/1095292788565868645/image.png ### Modification Made sure that we read an empty document if the headers option is not set. ### Result The header option is now optional as documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When including an inclusion that has no headers option set the following exception is thrown.
https://cdn.discordapp.com/attachments/818777626663321671/1095292788565868645/image.png
Modification
Made sure that we read an empty document if the headers option is not set.
Result
The header option is now optional as documented.