Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update openapi specs due to recent ServiceConfiguration changes #1218

Merged
merged 5 commits into from
May 9, 2023

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented May 7, 2023

Motivation

The OpenAPI specs had to be adapted due to the past changes to the service configuration. In addition, failure to create a service would lead to an exception on the node, as the ServiceCreationResult could not be serialized.

Modification

Adopted the changes in the OpenAPI specs and made the ServiceCreationResult a class resolving the serialization errors.

Result

The OpenAPI specs are up-to date and the serialization is working properly

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules labels May 7, 2023
@0utplay 0utplay added this to the 4.0.0-RC9 milestone May 7, 2023
@0utplay 0utplay requested a review from derklaro May 7, 2023 14:24
@0utplay 0utplay self-assigned this May 7, 2023
@0utplay 0utplay changed the title chore: update openapi specs chore: update openapi specs due to recent ServiceConfiguration changes May 7, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Test Results

  47 files  ±0    47 suites  ±0   1m 11s ⏱️ -1s
321 tests ±0  321 ✔️ ±0  0 💤 ±0  0 ±0 
651 runs  ±0  651 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 0deab4e. ± Comparison against base commit 859a7e7.

This pull request removes 15 and adds 15 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","this":"is","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 21396, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test2=test3, test=test1}, class java.lang.String, class java.lang.String
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] GJJWJUPZ3KDNG2WGMMJFEZTHM, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test2=456, test=123}, class java.lang.String, class java.lang.Integer
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 916995999, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:0830ab70-e9ad-4796-a5ce-db4ea434ef4b
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] {test2=[678, 456], test=[123, 456]}, class java.lang.String, java.util.List<java.lang.Integer>
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] 9079842698101443442, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] Optional[{test2=test3, test=test1}], java.util.Map<java.lang.String, java.lang.String>
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 5333, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test=test1, test2=test3}, class java.lang.String, class java.lang.String
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] JZ0LP6UU7GK6YTB3TC0K10BGX, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test=123, test2=456}, class java.lang.String, class java.lang.Integer
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 1509757196, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:da247833-ef3c-460c-847f-1ae18bbfa0c1
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] {test=[123, 456], test2=[678, 456]}, class java.lang.String, java.util.List<java.lang.Integer>
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] -5060379620261475384, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] Optional[{test=test1, test2=test3}], java.util.Map<java.lang.String, java.lang.String>
…

@derklaro derklaro added this pull request to the merge queue May 9, 2023
Merged via the queue into nightly with commit b8d51ed May 9, 2023
@derklaro derklaro deleted the update-open-api branch May 9, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: module An issue/pull request releated to one of the internal modules in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants