-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update openapi specs due to recent ServiceConfiguration changes #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
This pull should be included in the 4.0 release
in: node
An issue/pull request releated to the node module code
t: fix
A pull request introducing a fix for a bug.
in: module
An issue/pull request releated to one of the internal modules
labels
May 7, 2023
0utplay
changed the title
chore: update openapi specs
chore: update openapi specs due to recent ServiceConfiguration changes
May 7, 2023
Test Results 47 files ±0 47 suites ±0 1m 11s ⏱️ -1s Results for commit 0deab4e. ± Comparison against base commit 859a7e7. This pull request removes 15 and adds 15 tests. Note that renamed tests count towards both.
|
derklaro
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: module
An issue/pull request releated to one of the internal modules
in: node
An issue/pull request releated to the node module code
t: fix
A pull request introducing a fix for a bug.
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The OpenAPI specs had to be adapted due to the past changes to the service configuration. In addition, failure to create a service would lead to an exception on the node, as the ServiceCreationResult could not be serialized.
Modification
Adopted the changes in the OpenAPI specs and made the ServiceCreationResult a class resolving the serialization errors.
Result
The OpenAPI specs are up-to date and the serialization is working properly