fix: the launchers memory should not effect the node memory #1221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The way our launcher works is that all jvm options of the launcher get passed down to the started node instance. Therefore increasing the memory in one of the start files would result in the memory increasing for two different processes.
So that means that the memory consumption is doubled.
Modification
Made sure to remove the -xmx and -xms options of the launcher before passing the remaining options to the node and introduced a new option in the launcher.cnl.
The new option
cloudnet.node.memory
is the new way to set the memory of the node (in megabytes).Result
The memory is not occupied twice and the node memory is not dependant on the launcher.