Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly replace placeholders in syncproxy tablist #1254

Merged
merged 4 commits into from
Jul 9, 2023
Merged

fix: correctly replace placeholders in syncproxy tablist #1254

merged 4 commits into from
Jul 9, 2023

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Jun 11, 2023

Motivation

Due to recent changes in syncproxy placeholders the wrong replacements were used.

Modification

Replaced max_players and online_players before giving it into the common replacer as it might use wrong values.

Result

The replacements are correct and the displayed values too.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules labels Jun 11, 2023
@0utplay 0utplay added this to the 4.0.0-RC9 milestone Jun 11, 2023
@0utplay 0utplay requested a review from derklaro June 11, 2023 13:10
@0utplay 0utplay self-assigned this Jun 11, 2023
@0utplay 0utplay marked this pull request as ready for review June 11, 2023 13:10
@github-actions
Copy link

github-actions bot commented Jun 15, 2023 •
edited
Loading

Test Results

  47 files  ±0    47 suites  ±0   1m 15s ⏱️ -2s
322 tests ±0  322 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
652 runs  ±0  652 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9430ea2. ± Comparison against base commit 5a564d0.

♻️ This comment has been updated with latest results.

@byRoadrunner byRoadrunner merged commit 22de0ae into nightly Jul 9, 2023
@byRoadrunner byRoadrunner deleted the fix/syncproxy-placeholder branch July 9, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derklaro derklaro Awaiting requested review from derklaro

Assignees

@0utplay 0utplay

Labels
in: module An issue/pull request releated to one of the internal modules t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Milestone
4.0.0-RC9
Development

Successfully merging this pull request may close these issues.
2 participants
@0utplay @byRoadrunner