Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not set ssl explicitly to false and use mariadb 11.1.1-rc in tests #1256

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Jun 15, 2023

Motivation

When using never mysql db servers the module could not connect to the server due to the fact that useSSL is disabled explicitly

Modification

The useSSL option was removed completly.

Result

Connections with never versions are possible.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules labels Jun 15, 2023
@0utplay 0utplay added this to the 4.0.0-RC9 milestone Jun 15, 2023
@0utplay 0utplay requested a review from derklaro June 15, 2023 14:36
@0utplay 0utplay self-assigned this Jun 15, 2023
@0utplay 0utplay marked this pull request as ready for review June 15, 2023 14:36
@0utplay 0utplay changed the title fix: do not set ssl explicitly to false, use mariadb 11.1.1-rc in tests fix: do not set ssl explicitly to false and use mariadb 11.1.1-rc in tests Jun 15, 2023
@github-actions
Copy link

Test Results

  47 files  ±0    47 suites  ±0   1m 35s ⏱️ +26s
322 tests ±0  322 ✔️ ±0  0 💤 ±0  0 ±0 
652 runs  ±0  652 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 6e7a2b9. ± Comparison against base commit d29c6d9.

This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 6686, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] HWPY1A7KS0RHCKK4Y6TUQ9JMK, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 85548627, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:e48ce2e2-792f-47f5-b496-6d1a1ef3d4a1
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] 39739950743046893, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] ServiceInfoSnapshot(creationTime=1686304227772, address=127.0.1.1:99, processSnapshot=ProcessSnapshot[pid=2063, cpuUsage=89.58333333333334, systemCpuUsage=97.91666666666666, maxHeapMemory=536870912, heapUsageMemory=44011520, noHeapUsageMemory=58060056, unloadedClassCount=0, totalLoadedClassCount=8525, currentLoadedClassCount=8525, threads=[ThreadSnapshot[id=1, priority=5, daemon=false, name=Test worker, threadState=RUNNABLE], ThreadSnapshot[id=2, priority=10, daemon=true, name=Reference Handler, threadStat…
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [5] 0.67401683, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [6] 0.8482001215524269, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [7] true, null
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","hello":"world","insane":"!"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 30028, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] 3K4V7NUNZ481FZTE2RYICV6K9, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 97993369, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:79d09abb-bd65-47f4-80ca-2dd0805b9f13
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] 2014667140552246678, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] ServiceInfoSnapshot(creationTime=1686254354247, address=127.0.1.1:99, processSnapshot=ProcessSnapshot[pid=2244, cpuUsage=71.73913043478261, systemCpuUsage=100.0, maxHeapMemory=536870912, heapUsageMemory=26627792, noHeapUsageMemory=57705664, unloadedClassCount=1, totalLoadedClassCount=8525, currentLoadedClassCount=8524, threads=[ThreadSnapshot[id=1, priority=5, daemon=false, name=Test worker, threadState=RUNNABLE], ThreadSnapshot[id=2, priority=10, daemon=true, name=Reference Handler, threadState=RUNNABLE],…
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [5] 0.7501142, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [6] 0.42735851116987766, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [7] false, null
…

@derklaro derklaro merged commit c37d489 into nightly Jun 15, 2023
@derklaro derklaro deleted the fix/mysql-module branch June 15, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: module An issue/pull request releated to one of the internal modules t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants