-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: group configurations are not upgraded correctly #1274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utplay
added
v: 4.X
This pull should be included in the 4.0 release
in: node
An issue/pull request releated to the node module code
in: driver
An issue/pull request releated to the driver module code
t: fix
A pull request introducing a fix for a bug.
a: api
An issue/pull request that is related to api changes.
labels
Jul 10, 2023
Test Results 47 files ±0 47 suites ±0 1m 41s ⏱️ +4s Results for commit 00bacb8. ± Comparison against base commit 2693eb5. This pull request removes 21 and adds 21 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: api
An issue/pull request that is related to api changes.
in: driver
An issue/pull request releated to the driver module code
in: node
An issue/pull request releated to the node module code
t: fix
A pull request introducing a fix for a bug.
v: 4.X
This pull should be included in the 4.0 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When upgrading a v3 group to v4 the
environmentVariables
map must be added to the configuration. Due to the fact thatDocument#contains
does not check for a null value the map is not properly set and therefore results in an error when starting a service.Modification
Added a new method
containsNonNull
to the document that checks that the document contains a value mapping that is non-null.Result
Groups and tasks are converted correctly