Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: group configurations are not upgraded correctly #1274

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

0utplay
Copy link
Member

@0utplay 0utplay commented Jul 10, 2023

Motivation

When upgrading a v3 group to v4 the environmentVariables map must be added to the configuration. Due to the fact that Document#contains does not check for a null value the map is not properly set and therefore results in an error when starting a service.

Modification

Added a new method containsNonNull to the document that checks that the document contains a value mapping that is non-null.

Result

Groups and tasks are converted correctly

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code in: driver An issue/pull request releated to the driver module code t: fix A pull request introducing a fix for a bug. a: api An issue/pull request that is related to api changes. labels Jul 10, 2023
@0utplay 0utplay self-assigned this Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Test Results

 47 files  ±0   47 suites  ±0   1m 41s ⏱️ +4s
394 tests ±0  394 ✅ ±0  0 💤 ±0  0 ❌ ±0 
725 runs  +1  725 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 00bacb8. ± Comparison against base commit 2693eb5.

This pull request removes 21 and adds 21 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 28223, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [23] 2024-02-25T14:58:37.904522627Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [24] 2024-02-25T14:50:17.904525983Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] 6M8O8KFWEWGCSPALUX7834J7H, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] -124881644, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:bffd79f3-7829-4e61-9043-e73e0c00a2ed
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [47] 14:58:37.904707212
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] 247630368340615620, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] ServiceInfoSnapshot(creationTime=1708873117723, address=127.0.1.1:99, processSnapshot=ProcessSnapshot[pid=2177, cpuUsage=53.09734513274337, systemCpuUsage=100.0, maxHeapMemory=536870912, heapUsageMemory=27943184, noHeapUsageMemory=60425408, unloadedClassCount=1, totalLoadedClassCount=8666, currentLoadedClassCount=8665, threads=[ThreadSnapshot[id=1, priority=5, daemon=false, name=Test worker, threadState=RUNNABLE], ThreadSnapshot[id=2, priority=10, daemon=true, name=Reference Handler, threadState=RUNNABLE],…
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [56] 14:58:37.904810244Z
…
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 27031, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [23] 2024-02-25T15:03:28.498391145Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [24] 2024-02-25T14:55:08.498395113Z
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] PZK2JSEP3LG1VIJ0HIIBM8XMN, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] -1955610722, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:f1e3dbc3-8f23-4455-ab2c-9915c60dbaa6
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [47] 15:03:28.498706522
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] -4665257613380387129, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] ServiceInfoSnapshot(creationTime=1708873408227, address=127.0.1.1:99, processSnapshot=ProcessSnapshot[pid=2201, cpuUsage=26.570048309178745, systemCpuUsage=100.0, maxHeapMemory=536870912, heapUsageMemory=33255056, noHeapUsageMemory=59619192, unloadedClassCount=3, totalLoadedClassCount=8671, currentLoadedClassCount=8668, threads=[ThreadSnapshot[id=1, priority=5, daemon=false, name=Test worker, threadState=RUNNABLE], ThreadSnapshot[id=2, priority=10, daemon=true, name=Reference Handler, threadState=RUNNABLE]…
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [56] 15:03:28.498822789Z
…

♻️ This comment has been updated with latest results.

@0utplay 0utplay marked this pull request as ready for review February 25, 2024 15:01
@derklaro derklaro merged commit 12f4c86 into nightly Feb 25, 2024
5 checks passed
@derklaro derklaro deleted the fix/group-conversion branch February 25, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: api An issue/pull request that is related to api changes. in: driver An issue/pull request releated to the driver module code in: node An issue/pull request releated to the node module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants