fix: the npc inventory size should not exceed 54 #1306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The npc inventory has a dynamic size feature that scales the inventory based on the amount of services to display but that feature misses a upper bound of 54 (which is needed as minecraft inventories cant be bigger)
Modification
Extracted the inventory size calculation into a separate method and set a upper bound of 54.
Result
The inventory is created with a maximum of 54 slots.