Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #1437

Merged

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented May 31, 2024

Include:

  • Dev: Remove unused code about hb_delnode
  • Dev: crash_test.utils: Reuse color constants from crmsh.constants
  • Dev: ui_configure: Remove _keywords interface and unused code

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (a1e0fb1) to head (427d4f3).
Report is 10 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 53.77% <0.00%> (?)
unit 50.36% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/config.py 81.54% <ø> (ø)
crmsh/constants.py 100.00% <ø> (ø)
crmsh/crash_test/utils.py 90.00% <100.00%> (+90.00%) ⬆️
crmsh/ui_configure.py 43.72% <ø> (-0.10%) ⬇️
crmsh/ui_node.py 43.84% <ø> (-0.15%) ⬇️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 force-pushed the 20240531_remove_unused_code branch from fe8b207 to d7020ee Compare June 3, 2024 01:58
which was not useful and easily outdated
@liangxin1300 liangxin1300 force-pushed the 20240531_remove_unused_code branch from d7020ee to 427d4f3 Compare June 3, 2024 02:03
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the colors, there are still 2 variants: one is in constants, the other is in term. It is worth to create a issue to track it.

@liangxin1300 liangxin1300 mentioned this pull request Jun 20, 2024
@liangxin1300
Copy link
Collaborator Author

For the colors, there are still 2 variants: one is in constants, the other is in term. It is worth to create a issue to track it.

I've created one issue #1467 to track this
Then I think this PR is ready to go

@liangxin1300 liangxin1300 merged commit 4dcac18 into ClusterLabs:master Jun 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants