Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ui_context: crm configure delete autocompletion #1403 #1460 #1469

Conversation

aleksei-burlakov
Copy link
Contributor

If you type
$ crm configure delete
of do it interactively
$ crm configure
crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options. And this commit makes it working again.

@@ -255,6 +255,8 @@ def enter_level(self, level):
self._in_transit = True

entry = level()
if 'requires' in dir(entry) and not entry.requires():
self.fatal_error("Missing requirements")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will bring the issue #1355 back, which was fixed in #1300

@aleksei-burlakov aleksei-burlakov changed the title Fix: ui_context: crm cluster delete autocompletion #1403 #1460 Fix: ui_context: crm configure delete autocompletion #1403 #1460 Jun 24, 2024
@aleksei-burlakov aleksei-burlakov force-pushed the fix-crm-conf-delete-autocomplete branch 2 times, most recently from 5be7bb6 to 15ec6c2 Compare June 25, 2024 09:04
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@fe4d011). Learn more about missing BASE report.
Report is 15 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 53.93% <75.00%> (?)
unit 52.34% <25.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/ui_context.py 58.17% <75.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleksei-burlakov aleksei-burlakov force-pushed the fix-crm-conf-delete-autocomplete branch from 15ec6c2 to d1c3657 Compare June 25, 2024 12:21
@@ -255,6 +255,9 @@ def enter_level(self, level):
self._in_transit = True

entry = level()
if self.command_name == 'configure' and self.command_args and self.command_args[0] in ['delete']:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found issue #1466 might have the same root cause
It works after running configure refresh

So here we should think a common solution, not only for the delete command

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, #1403 cause this and #1466 both

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @liangxin1300 , could you please check the update?

…lusterLabs#1460

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
@aleksei-burlakov aleksei-burlakov force-pushed the fix-crm-conf-delete-autocomplete branch from d1c3657 to 3812503 Compare June 27, 2024 09:51
Copy link
Collaborator

@liangxin1300 liangxin1300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aleksei-burlakov !

@liangxin1300 liangxin1300 merged commit 3b3d7ee into ClusterLabs:master Jun 28, 2024
31 checks passed
@liangxin1300
Copy link
Collaborator

Please backport this to crmsh-4.6

@liangxin1300
Copy link
Collaborator

And also take a look at issue #1466 when you have time
Thanks!

aleksei-burlakov pushed a commit to aleksei-burlakov/crmsh that referenced this pull request Jul 1, 2024
…rLabs#1403 ClusterLabs#1460

backport ClusterLabs#1469

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
liangxin1300 added a commit that referenced this pull request Jul 1, 2024
…1460 (#1480)

backport #1469

If you type
  $ crm configure delete
of do it interactively
  $ crm configure
  crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options.
And this commit makes it working again.
@aleksei-burlakov aleksei-burlakov deleted the fix-crm-conf-delete-autocomplete branch July 8, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants