-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ui_context: crm configure delete autocompletion #1403 #1460 #1469
Fix: ui_context: crm configure delete autocompletion #1403 #1460 #1469
Conversation
crmsh/ui_context.py
Outdated
@@ -255,6 +255,8 @@ def enter_level(self, level): | |||
self._in_transit = True | |||
|
|||
entry = level() | |||
if 'requires' in dir(entry) and not entry.requires(): | |||
self.fatal_error("Missing requirements") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5be7bb6
to
15ec6c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
15ec6c2
to
d1c3657
Compare
crmsh/ui_context.py
Outdated
@@ -255,6 +255,9 @@ def enter_level(self, level): | |||
self._in_transit = True | |||
|
|||
entry = level() | |||
if self.command_name == 'configure' and self.command_args and self.command_args[0] in ['delete']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found issue #1466 might have the same root cause
It works after running configure refresh
So here we should think a common solution, not only for the delete
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @liangxin1300 , could you please check the update?
…lusterLabs#1460 If you type $ crm configure delete of do it interactively $ crm configure crm(live/node1)configure# delete and then double press tab it, should propose possible resource options. And this commit makes it working again.
d1c3657
to
3812503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aleksei-burlakov !
Please backport this to crmsh-4.6 |
And also take a look at issue #1466 when you have time |
…rLabs#1403 ClusterLabs#1460 backport ClusterLabs#1469 If you type $ crm configure delete of do it interactively $ crm configure crm(live/node1)configure# delete and then double press tab it, should propose possible resource options. And this commit makes it working again.
If you type
$ crm configure delete
of do it interactively
$ crm configure
crm(live/node1)configure# delete
and then double press tab it, should propose possible resource options. And this commit makes it working again.