Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option 'add_advised_op_values' to disable adding advised op values #1494

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Jul 24, 2024

This PR is for issue #1442

The default value for add_advised_op_values is 'yes'.
When set to 'no', the advised operation values will not be added automatically if the user has not specified them

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (6803994) to head (b966903).

Additional details and impacted files
Flag Coverage Δ
integration 54.25% <90.00%> (ø)
unit 52.47% <90.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/cibconfig.py 63.66% <100.00%> (ø)
crmsh/config.py 81.48% <ø> (ø)
crmsh/parse.py 85.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review July 24, 2024 10:32
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangxin1300 liangxin1300 force-pushed the 20240724_disable_autoadd_operation_values branch from b966903 to 697716c Compare August 12, 2024 11:56
@liangxin1300 liangxin1300 merged commit 49aeacf into ClusterLabs:master Aug 12, 2024
29 checks passed
liangxin1300 added a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants