Dev: crm_rpmcheck: use ansible to get package versions #1497
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aleksei-burlakov
force-pushed
the
rpmcheck-ansible
branch
from
675dffc to
01fb54e
Compare
utils/crm_rpmcheck.py
Outdated
| @@ -23,6 +23,11 @@ def package_data(pkg): | |||
| """ | |||
| Gathers version and release information about a package. | |||
| """ | |||
| if os.path.isfile('/bin/ansible'): | |||
There was a problem hiding this comment.
Should use shutil.which instead, as it works better with environ PATH and also checks for 'x' permission.
There was a problem hiding this comment.
My idea was to make the code uniform. So that it looked like the rest. Like
if os.path.isfile('/bin/rpm'):
and
if os.path.isfile('/usr/bin/dpkg'):
look all the same.
I could use the shutil.which indeed, but that would logically require refactoring the /bin/rpm and /bin/dpkg cases.
There was a problem hiding this comment.
So this is a good time to refactor them.
utils/crm_rpmcheck.py
Outdated
| @@ -31,6 +36,37 @@ def package_data(pkg): | |||
|
|
|||
| return {'name': pkg, 'error': "unknown package manager"} | |||
|
|
|||
| packages = None | |||
There was a problem hiding this comment.
Private variables, which is not intended to be accessed directly from other modules, should start with _.
aleksei-burlakov
force-pushed
the
rpmcheck-ansible
branch
from
01fb54e to
3538203
Compare
This PR continues the #1497 . Additionally to the package information it is also the system information that read from ansible.
This PR introduces
ansibleand this change is just the right place. Instead of repeatedly callingrpm -q ...it calls ansible only once and gets all the package information.