Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ui_context: enter_level() should not check requirements for non-functional subcommands #1498

Conversation

nicholasyang2022
Copy link
Collaborator

Fix a regression introduced in ac812f1.

…functional subcommands

Fix a regression introduced in ac812f1.
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.55%. Comparing base (6803994) to head (99d6430).

Additional details and impacted files
Flag Coverage Δ
integration 54.26% <75.00%> (+<0.01%) ⬆️
unit 52.46% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/ui_context.py 58.62% <75.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review July 30, 2024 07:28
Copy link
Collaborator

@liangxin1300 liangxin1300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@liangxin1300 liangxin1300 merged commit 2abacf2 into ClusterLabs:master Jul 31, 2024
31 checks passed
@nicholasyang2022 nicholasyang2022 deleted the fix-enter-level-non-functional-requirements branch August 16, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants