Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: report: Fix a regression for irregular file collection #1620

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

liangxin1300
Copy link
Collaborator

Single irregular file like crm.conf and profiles.yml are not collected, which was introduced by commit 210661b.

Should determine if the file does have archived logs first.

Single irregular file like crm.conf and profiles.yml are not collected,
which was introduced by commit 210661b.

Should determine if the file does have archived logs first.
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.21%. Comparing base (ae21432) to head (742b0ef).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 54.43% <0.00%> (+<0.01%) ⬆️
unit 52.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/report/utils.py 99.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review November 27, 2024 01:48
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangxin1300 liangxin1300 merged commit 3e90e46 into ClusterLabs:master Nov 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants