Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Dev: pre-migration: implement pre-migration checks for corosync 3 (jsc#PED-11808) #1629

Draft
wants to merge 8 commits into
base: crmsh-4.6
Choose a base branch
from

Conversation

nicholasyang2022
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 commented Dec 13, 2024

This pull request implements pre-migration checks for corosync 3. These checks are expected to run before upgrading corosync package to 3.x.

These checks ensure all the cluster nodes runs the latest version of corosync 2.x, and report further actions need to take after upgrading the corosync package.


Use Cases

crm cluster health sles16

> sudo crm cluster health sles16
------ ha-1-2 ------
[WARN] Corosync transport "udpu" will be deprecated in corosync 3.
       After migrating to SLES 16, run "crm health sles16 --fix" to migrate it to transport "knet".
[PASS]

------ localhost ------
[INFO] Checking dependency version...
[INFO] Checking service status...
[INFO] Checking used corosync features...
[WARN] Corosync transport "udpu" will be deprecated in corosync 3.
       After migrating to SLES 16, run "crm health sles16 --fix" to migrate it to transport "knet".
[PASS]

crm cluster health sles16 --fix

> sudo crm cluster health sles16 --fix
ERROR: "--fix" is only available in SLES 16.

@nicholasyang2022 nicholasyang2022 changed the title [crmsh] Dev: pre-migration: implement pre-migration checks for corosync 3 (jsc#PED-8252) [crmsh-4.6] Dev: pre-migration: implement pre-migration checks for corosync 3 (jsc#PED-8252) Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 31.13208% with 146 lines in your changes missing coverage. Please review.

Project coverage is 66.75%. Comparing base (a6a2678) to head (d9038c6).

Files with missing lines Patch % Lines
crmsh/migration.py 25.43% 129 Missing ⚠️
crmsh/ui_cluster.py 57.14% 15 Missing ⚠️
crmsh/xmlutil.py 50.00% 2 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 52.51% <31.13%> (-0.23%) ⬇️
unit 49.44% <22.16%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/xmlutil.py 69.12% <50.00%> (-0.09%) ⬇️
crmsh/ui_cluster.py 73.06% <57.14%> (-1.75%) ⬇️
crmsh/migration.py 25.43% <25.43%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzhou1 zzhou1 changed the title [crmsh-4.6] Dev: pre-migration: implement pre-migration checks for corosync 3 (jsc#PED-8252) [crmsh-4.6] Dev: pre-migration: implement pre-migration checks for corosync 3 (jsc#PED-11808) Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant