Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: utils: Change get_dc function as the behavior of crmadmin -D changed #1632

Merged

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Dec 16, 2024

The behavior of crmadmin -D changed when no DC elected
original:

# crmadmin -D -t 1
error: Timed out after 1000ms waiting for reply from controller API on DC
error: Command failed: Resource temporarily unavailable

now:

# crmadmin -D -t 1
Designated Controller is: not yet elected

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.56%. Comparing base (2731077) to head (231425e).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 53.85% <100.00%> (+0.02%) ⬆️
unit 52.76% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/utils.py 66.45% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review December 16, 2024 11:52
@liangxin1300 liangxin1300 merged commit 562ce84 into ClusterLabs:master Dec 17, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants