Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instrumentation to the exporter itself by introducing a new interface for the existing collectors, called
InstrumentableCollector
, and wrapping these in a newInstrumentedCollector
concrete implementation, which adds the following two metrics to each collector, using a constant label (i.e. a label that never changes in a time series):These metrics take inspiration from
node_exporter
.Some significant refactoring was contextually performed to the main
run()
function, to add some test coverage to it.Closes #159