Skip to content

Commit

Permalink
Add comments about issues to be adressed in the future
Browse files Browse the repository at this point in the history
  • Loading branch information
Clyybber committed Mar 12, 2024
1 parent a1deb7a commit a845c19
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions compiler/ast/trees.nim
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,14 @@ template makeTreeEquivalenceProc*(
of nkIdent: result = a.ident.id == b.ident.id
of nkIntLiterals: result = a.intVal == b.intVal
of nkFloatLiterals: result = floatCheck
# XXX: Using float equality, even if partially tamed through
# sameFloatIgnoreNan, causes inconsistencies due to it lacking
# the substition and reflexivity property.
of nkStrLiterals: result = a.strVal == b.strVal
of nkType: result = typeCheck
of nkCommentStmt: result = commentCheck
# XXX: nkNimNodeLit should probably always be checked strictly.
# Currently this doesn't matter as only nkSym NimNode literals are created
of nkWithSons:
if a.len == b.len:
for i in 0..<a.len:
Expand Down

0 comments on commit a845c19

Please sign in to comment.