Fix vertex.inspect
#145
Open
Fix vertex.inspect
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fails in bundler when doing `dependency_graph.inspect` as ruby and rubygems dependencies are named "Ruby\0" and "RubyGems\0" which causes a `ArgumentError` with message `string contains null byte`
|
Should we add a test covering this? is it potentially an encoding issue? |
I could only reproduce it while using inside bundler. I've tried causing the error using just a string, and even various components with no luck. It's quite weird how it is happening. So unfortunately I wasn't able to come up with an independent test. I'm guessing it's not used very often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails in bundler when doing
dependency_graph.inspectas ruby and rubygems dependencies are named"Ruby\0"and"RubyGems\0".The call will cause an
ArgumentErrorwith messagestring contains null byte.There appears to be some bug in how inspect is called, as testing inspect on a string with a null byte such as
"Ruby\0"works without issue.