-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the files for the pod into a folder with the same name as the project #152
Conversation
@@ -26,12 +27,11 @@ Pod::Spec.new do |s| | |||
s.source = { :git => "https://github.com/<GITHUB_USERNAME>/${POD_NAME}.git", :tag => s.version.to_s } | |||
# s.social_media_url = 'https://twitter.com/<TWITTER_USERNAME>' | |||
|
|||
s.platform = :ios, '7.0' | |||
s.requires_arc = true | |||
s.platform = :ios, '8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love it if we switched this to using the deployment targets syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
Shouldn't this use |
I've not studied spm, probably should |
Per #78 (comment) this issue harmonizes CocoaPods and SwiftPM directory layouts. (I also recently found out Carthage is already harmonized.) Can this issue please be renamed to
or
|
It can, but I have to be devoting my time to CP.app for a while, so if it's something you want to pick up, it may be better to make a separate issue for that, and consider taking it from this point forwards |
@orta Right now I am not really understanding the issue. I don't understand what is motivating the change in directory structures. But if the intent in this issue is to achieve compliance with SwiftPM then that could be made more clear with the above note. And also, I will be able to move in the right direction. |
I just found putting the files in |
Ok. I am +1 for merging this PR now. Also I have create #157 to continue discussing directory layout and SwiftPM compatibility. |
A +1 on #157 will assist in getting more people interested in that task, which I am working on. |
In the current version, your files would go into
Pod/Classes/Here.swift
but I think overall, it's less confusing to have them go into[LibName]/Classes/Here.swift
.Other than that, done some minor cleanup.