Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Add support for category in page permalinks #189

Merged
merged 1 commit into from
Jan 10, 2015
Merged

Conversation

dkarzon
Copy link
Contributor

@dkarzon dkarzon commented Jan 9, 2015

We use categories in our permalinks because reasons. 🎱

Here are the docs: http://jekyllrb.com/docs/permalinks/

@laedit
Copy link
Member

laedit commented Jan 9, 2015

I'm good with the "show only a specific category" but why the limit to 3?
Could you make it more generic?

Also there is no reference to :category1 and other in the jekyll doc, do you want to have a "categoty1/category2" url instead of the current "category1-category2"?

@dkarzon
Copy link
Contributor Author

dkarzon commented Jan 9, 2015

Looks like I might have read that doco page wrong but our usage is to only use the first category in the url so the :categories parameter doesn't do what we need.

@dkarzon
Copy link
Contributor Author

dkarzon commented Jan 9, 2015

Also, with making it generic. I tried only loading it based on the number of categories on the page but if there are no categories it would not remove the category1 placeholder so it would fail when creating the directory.

@laedit
Copy link
Member

laedit commented Jan 9, 2015

I'll try to provide a generic solution, but if I fail I'll merge your PR.
Is that ok for you?

@laedit laedit merged commit b647729 into Code52:master Jan 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants