-
Notifications
You must be signed in to change notification settings - Fork 163
Conversation
@thiagoabreu this is amazing! Thanks for looking into this ❤️❤️❤️❤️❤️ There's some failing tests on this project - you can see the output here - have you had a chance to look into them? |
I'll let @laedit chime in here as he's been steering a bunch of this stuff recently. Also cc @vikingcode as he was looking at Mono support earlier... |
Found a bug in generating permalinks. Fixed now. |
Fixing author (sorry, my bad) |
I suspect some related code smell at https://github.com/Code52/pretzel/blob/master/src/Pretzel.Logic/Extensibility/Extensions/AzureHostSupport.cs#L46 and in line 52. I think the replacement target should be changed to PathSeparatorChar. |
Agreed. The output is the same but the SeparatorChar makes clearer understanding. |
Hey, @shiftkey can you see what happened? 😅 |
Sorry for the silence, I was out of town for a few weeks. |
Sounds good to me, thanks again! 😃
|
Conflicts: src/Pretzel.Logic/Extensions/StringExtensions.cs
Done.
Travis is ok. The mono-project guys use Jenkins. The TeamCity also supports Mono. Just a reminder, my branch does not compile on Mono. The mono compiler reflection can't find all the Command tags, making Pretzel useless. |
Thanks! |
Yes. Compile on Windows + .NET Framework, test on Unix + Mono. That's one reason I didn't change the tests: I couldn't figure out how to set the mock file system to Unix style while at Windows. The other reason is I didn't want to brake the Windows implementation. 😅 |
Hey guys. I recently read about this project and I was wondering if it runs on Mono.
I tried to run the .exe file and, joyfully, it worked. I mean, almost. It had some issues with the paths of the generated files but seems like all the libs were compatible. I saw you were working on it ( #215 ) and, as a Mono developer, I tried to figure out what was happening.
It was only a matter of fixing lower cases paths and using System.IO.Path instead of changing path strings.
I compiled on VS 2015 RT (Windows 10) and tested in my Xubuntu machine with Mono 4.0. I'm able to run commands hungry (no big deal here), create, bake and taste, both with Razor and Liquid templates. It worked and was delicious.
I had problems running the automated tests, though. And didn't test the "import" command. I need some help with that.
Anyway, hope it's usefull. :D