Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@/ui Callable Workflows #937

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

@/ui Callable Workflows #937

wants to merge 17 commits into from

Conversation

kilemensi
Copy link
Member

@kilemensi kilemensi commented Oct 7, 2024

Description

To improve the performance of our workflows, it's important to reduce duplication as much as possible. Especially if we'd need to add multi platform support to our docker images.

This PR starts the process of fine-tuning the workflows by introducing callable workflows.

Supported apps:

  • charterafrica
  • codeforafrica

Note

More apps will be added but to make sure the PR can be clearly reviewed and understood, 2 apps should be enough to show if this approach makes sense or not. Here is an example of how various actions are activated.

Type of change

  • Chore

Screenshots

Screenshot 2024-10-08 at 09 37 48

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-937 Visit

@kilemensi kilemensi self-assigned this Oct 8, 2024
@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label Oct 8, 2024
@kilemensi kilemensi requested a review from a team October 8, 2024 06:38
@kilemensi kilemensi marked this pull request as ready for review October 8, 2024 06:39
@@ -1,102 +1,102 @@
name: Code for Africa | Deploy | REVIEW APP
# name: Code for Africa | Deploy | REVIEW APP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we doing away with this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we figure out how to make review apps work with all the apps, I'm inclined to say yes.

@kilemensi kilemensi requested a review from a team October 9, 2024 12:16
@koechkevin
Copy link
Contributor

I'm voting for this approach @kilemensi for the ease of adding a workflow for a new project. I'm thinking of edge cases that this wouldn't work and I can't find one. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that needs to be done (neither enhancement or bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants