-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@/ui Callable Workflows #937
base: main
Are you sure you want to change the base?
Conversation
Uses callable workflows
1. codeforafrica 2. charterafrica
Latest updated Preview URL
|
@@ -1,102 +1,102 @@ | |||
name: Code for Africa | Deploy | REVIEW APP | |||
# name: Code for Africa | Deploy | REVIEW APP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we doing away with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we figure out how to make review apps work with all the apps, I'm inclined to say yes.
I'm voting for this approach @kilemensi for the ease of adding a workflow for a new project. I'm thinking of edge cases that this wouldn't work and I can't find one. 🚀 |
Description
To improve the performance of our workflows, it's important to reduce duplication as much as possible. Especially if we'd need to add multi platform support to our docker images.
This PR starts the process of fine-tuning the workflows by introducing callable workflows.
Supported apps:
charterafrica
codeforafrica
Note
More apps will be added but to make sure the PR can be clearly reviewed and understood, 2 apps should be enough to show if this approach makes sense or not. Here is an example of how various actions are activated.
Type of change
Screenshots
Checklist: