-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@/Climatemapped Africa styling issues improvement. #996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might not achieve perfect left alignment on Map @kilemensi because of how react leaflet styles the map canvas by centering it based on zoom. We'd need a very high level of calculations on every map to get the perfect dimensions. |
Adjust the alignment of the Hero Map component in the Climatemapped Africa app to align items at the bottom instead of the center. Also, increase the height of the component from 80 to 108 pixels for better vertical alignment.
💯 @koechkevin ... we don't need it to be pixel perfect for now, lets just make sure it's not noticeable/obvious. And the fact that we can change zoom in the CMS, it means we can perfect it without code change, right? |
PS: My Internet today is dog slow @koechkevin so don't wait for my approval; if others have approved, go ahead and merge. |
We don't change zoom in the CMS, this is done in code |
Then you're on your own there @koechkevin 🏃🏽♂️ |
Adjust the zoom levels for the Hero Map component in the Climatemapped Africa app based on the device type on payloadcms. On desktop, set the zoom level to 3, and on mobile, set it to 2. This ensures that the map appears correctly on different devices.
Moved to CMS |
Description
This PR fixes a few issues with climate mapped Africa
Fixes #
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: