Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set_password() when creating user in factory #543

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Use set_password() when creating user in factory #543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions backend/fleet_management/factories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import random

from django.utils.timezone import now
from django.contrib.auth.hashers import make_password
from factory import (
fuzzy,
DjangoModelFactory,
Expand Down Expand Up @@ -39,7 +38,7 @@ class Meta:
def _create(cls, model_class, *args, **kwargs):
groups = kwargs.pop("groups", [])
user = super()._create(model_class, *args, **kwargs)
user.password = make_password(user.password)
user.set_password(cls.password)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you found that 👍

for g in groups:
user.groups.add(g)
user.save()
Expand Down