Add New Drive View #584
Add New Drive View #584
Conversation
…ForPoznan#556) * Add CarCountryFilter for more advanced filtering in admin panel * Enable CarCountryFilter on Refuel admin view * Add Car Country column in Refuel admin view
* PAH-557 add Kurdish translation * add kurdistan flag * fix linter * replace corrupted and missing translations to english, add iraq flag
… react-revolution
…d LF end of line)
| @@ -0,0 +1,2 @@ | |||
| # Convert to LF line endings on checkout. | |||
| *.sh text eol=lf | |||
frontend-react/src/routes.js
Outdated
| { | ||
| path: '/drive', | ||
| key: routeKeys.DRIVE, | ||
| component: lazy(() => import('./views/Add Drive')) |
There was a problem hiding this comment.
space? I don't think that's a good idea
| component: lazy(() => import('./views/Add Drive')) | |
| component: lazy(() => import('./views/AddDrive')) |
| @@ -0,0 +1,208 @@ | |||
| import React, { useState, useEffect } from 'react'; | |||
There was a problem hiding this comment.
as above, please rename it to AddDrive
|
|
||
| const validationSchema = yup.object().shape({ | ||
| startLocation: yup.string().required(useT('Start location is required')), | ||
| mileageStart: yup.string().required(useT('Starting mileage is required')), |
There was a problem hiding this comment.
why string? this doesn't align with initialValues
| })} | ||
| </Box> | ||
| <p> | ||
| {traveled} km {useT('traveled')} |
There was a problem hiding this comment.
| {traveled} km {useT('traveled')} | |
| {traveled} km {traveledT} |
please keep the useT out of returned JSX template, it's easier to find them when they're at the beginning of the function rather than somewhere in the returned template.
…ged validation types in yup to number for mileage start and end, extracted traveledT variable otside JSX.)
|
Fixed issues mentioned above in the latest commit :) |
frontend-react/src/routes.js
Outdated
| { | ||
| path: '/drive', | ||
| key: routeKeys.DRIVE, | ||
| component: lazy(() => import('./views/AddDrive')) |
There was a problem hiding this comment.
Sorry for pointing it out only now, but there's one inconsistency - this view is mapped under /drive, key is named DRIVE and the class is named DriveView, but the directory is named AddDrive. Can you rename it again to Drive?
I'm sorry for pointing it out this late but I just noticed that.
There was a problem hiding this comment.
No problem, I also was thinking about this inconsistency. Thank you for pointing this.
Add New Drive View. (#583)