Skip to content

Commit

Permalink
fix(src/index.js): add accessibility support for tabbing (#695)
Browse files Browse the repository at this point in the history
  • Loading branch information
jshaw22 authored Apr 25, 2021
1 parent 9006d11 commit ae936a5
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ class ReactTooltip extends React.Component {
}

target.addEventListener('mouseenter', this.showTooltip, isCaptureMode);
target.addEventListener('focus', this.showTooltip, isCaptureMode);
if (effect === 'float') {
target.addEventListener(
'mousemove',
Expand All @@ -296,6 +297,7 @@ class ReactTooltip extends React.Component {
);
}
target.addEventListener('mouseleave', this.hideTooltip, isCaptureMode);
target.addEventListener('blur', this.showTooltip, isCaptureMode);
});
}

Expand Down Expand Up @@ -401,6 +403,11 @@ class ReactTooltip extends React.Component {
scrollHide = this.props.scrollHide;
}

// adding aria-describedby to target to make tooltips read by screen readers
if (e && e.currentTarget && e.currentTarget.setAttribute) {
e.currentTarget.setAttribute('aria-describedby', this.state.uuid);
}

// Make sure the correct place is set
const desiredPlace =
e.currentTarget.getAttribute('data-place') || this.props.place || 'top';
Expand Down Expand Up @@ -621,6 +628,11 @@ class ReactTooltip extends React.Component {
if (!isMyElement || !this.state.show) return;
}

// clean up aria-describedby when hiding tooltip
if (e && e.currentTarget && e.currentTarget.removeAttribute) {
e.currentTarget.removeAttribute('aria-describedby');
}

const resetState = () => {
const isVisible = this.state.show;
// Check if the mouse is actually over the tooltip, if so don't hide the tooltip
Expand Down Expand Up @@ -737,7 +749,7 @@ class ReactTooltip extends React.Component {
}

render() {
const { extraClass, html, ariaProps, disable } = this.state;
const { extraClass, html, ariaProps, disable, uuid } = this.state;
const content = this.getTooltipContent();
const isEmptyTip = this.isEmptyTip(content);
const style = generateTooltipStyle(
Expand Down Expand Up @@ -773,7 +785,7 @@ class ReactTooltip extends React.Component {
return (
<Wrapper
className={`${wrapperClassName}`}
id={this.props.id}
id={this.props.id || uuid}
ref={ref => (this.tooltipRef = ref)}
{...ariaProps}
data-id="tooltip"
Expand All @@ -784,7 +796,7 @@ class ReactTooltip extends React.Component {
return (
<Wrapper
className={`${wrapperClassName}`}
id={this.props.id}
id={this.props.id || uuid}
{...ariaProps}
ref={ref => (this.tooltipRef = ref)}
data-id="tooltip"
Expand Down

0 comments on commit ae936a5

Please sign in to comment.