Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added animation #252

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

harshmishra19
Copy link
Contributor

Related Issue

This PR fixes #250

Description

I have added the animation

Type of PR

  • Bug fix
  • [ X] Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / Videos (if applicable)

datatilt.mp4

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • [ x] I have performed a self-review of my code.
  • [ x] I have read and followed the Contribution Guidelines.
  • [ x] I have tested the changes thoroughly before submitting this pull request.
  • [ x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [x ] I have commented my code, particularly in hard-to-understand areas.

Additional Context

[Include any additional information or context that might be helpful for reviewers.]

Resources for Guidance

Here are some resources that may be helpful as you contribute to CodeHarborHub:

Resources for DSA Features on Our Site:

Copy link

vercel bot commented May 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 3:09pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 Thank you for submitting your first pull request to CodeHarborHub. We appreciate your contribution! Our team will review it soon. If you have any questions or need further assistance, feel free to reach out.

Copy link
Contributor

deepsource-io bot commented May 26, 2024

Here's the code health analysis summary for commits 08491bd..9ee1e25. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 44 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

sonarcloud bot commented May 26, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/components/HomePage/vanilla-tilt.js Show resolved Hide resolved
@ajay-dhangar ajay-dhangar added enhancement New feature or request GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels May 26, 2024
@ajay-dhangar
Copy link
Member

Good work, only debug some code and make good code for us.

Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, I merged in this time and next time you try to follow best practice rules.

@ajay-dhangar ajay-dhangar merged commit 1897edd into CodeHarborHub:main May 27, 2024
7 of 8 checks passed
@harshmishra19
Copy link
Contributor Author

YESS!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature Request: Adding Animation
2 participants