Fix Docker build and prevent unnecessary rebuilds #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a Bazel issue (bazelbuild/bazel#17158), the recent introduction of `universal_binary` ended up forking the configuration for dependencies of the Jazzer launcher. As a result, some Java targets were built twice and the Docker images failed to build as the Jazzer standalone jar was no longer a dependency of the launcher in the default configuration. As a workaround and also because it prevents similar issues on a more fundamental level, switch to the soon to be default improved config hash algorithm.
kyakdan
approved these changes
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a Bazel issue (bazelbuild/bazel#17158), the recent introduction of
universal_binaryended up forking the configuration for dependencies of the Jazzer launcher. As a result, some Java targets were built twice and the Docker images failed to build as the Jazzer standalone jar was no longer a dependency of the launcher in the default configuration.As a workaround and also because it prevents similar issues on a more fundamental level, switch to the soon to be default improved config hash algorithm.