Robase hsm #6
Robase hsm #6
Conversation
ckdavid
force-pushed
the
robase-hsm
branch
2 times, most recently
from
c28b79a to
b0d6058
Compare
| @@ -0,0 +1,121 @@ | |||
| local Fsm = require(script.Parent.Fsm) | |||
There was a problem hiding this comment.
Is this the standard convention for Robase now? I seem to remember we were evaluating baste at one point
There was a problem hiding this comment.
We can use Roblox requires in lemur tests, so I don't see a downside.
lib/Hsm.lua
Outdated
| hsm, | ||
| { | ||
| __index = function(_, key) | ||
| if Hsm[key] then |
There was a problem hiding this comment.
Is it right to be polluting the Hsm namespace with arbitrary name bindings?
There was a problem hiding this comment.
It is assumed that the names are events, and if there is no such event, it will resolve to nil, so calling the event will cause an error, as for the underlying fsm library.
| initial = {state = initial} | ||
| elseif not initial then | ||
| initial = {state = "none"} | ||
| end |
| @@ -50,7 +50,7 @@ luac.out | |||
| /robase-venv | |||
|
|
|||
| # JUnit test report | |||
| /testReport.xml | |||
There was a problem hiding this comment.
The output file for test runs has been renamed in the Jenkinsfile.
| @@ -44,7 +44,12 @@ pipeline { | |||
|
|
|||
| stage('Tests') { | |||
| steps { | |||
| sh 'rm -f luacov.stats.* luacov.report.* testReport.xml cobertura.xml && ./test.sh --verbose --coverage --output junit > testReport.xml && ./lua_install/bin/luacov-cobertura -o cobertura.xml' | |||
| sh ''' | |||
There was a problem hiding this comment.
Rather than redirecting the test output, which includes print statements, it uses -Xoutput to pass in the name of the output file. It also strips whitespace lines from the report.
No description provided.