Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Refactor the project #71

Open
Pradyuman7 opened this issue Oct 22, 2020 · 7 comments
Open

Refactor the project #71

Pradyuman7 opened this issue Oct 22, 2020 · 7 comments
Labels
good first issue Good for newcomers Hacktoberfest Contribute for Hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed

Comments

@Pradyuman7
Copy link
Member

Similar type code directories should be placed inside a parent directory. Example:
Many code directories are just algorithms, they can be placed inside a parent directory with name algorithms.

@Pradyuman7 Pradyuman7 added help wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest Contribute for Hacktoberfest hacktoberfest-accepted labels Oct 22, 2020
widlok pushed a commit to widlok/Let-Us-Java that referenced this issue Oct 22, 2020
Created maven modules for code that didnt have them.
widlok pushed a commit to widlok/Let-Us-Java that referenced this issue Oct 22, 2020
All algorithms implementations moved to new module 'Algorithms'. All games implementations modules moved to module new 'Games'.
Small naming refactoring so maven doesn't yell at me.
@widlok
Copy link

widlok commented Oct 22, 2020

Existing code in repo contains errors. Two classes have mismatch between class name and .java file name

class TopKFrequentElements in TopKFrequent.java

and

class SinglyLinkedList in LinkedListOperations.java.

I'll fix classes that causes errors and commit - I'll use class names as template for file names as I assume they have priority.

@Pradyuman7
Copy link
Member Author

Clean up the code and refactor it to remove all the irregularities introduced by new PRs

@Pradyuman7
Copy link
Member Author

For this issue, please make sure you do the following stuff:

  1. Merge directories that have similar code content and remove duplicate codes in the merged directories
  2. Make each directory a maven module properly
  3. Simple clean up that you find fit

@sam5O5
Copy link

sam5O5 commented Oct 27, 2021

Hi I am new to the open source can you please tell me how can I start with the contribution

@Pradyuman7
Copy link
Member Author

@sam5O5 this particular issue has some guidelines mentioned above that you have to keep in mind. Other than that, you can refer these resource to know more about contributing to open source in general, here and here

@jawadkhanpk
Copy link

Hi, I would like to contribute to this issue.

@MehakSingla21
Copy link

Hii ! Can you assign me this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers Hacktoberfest Contribute for Hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants