Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/automatic admins publication #45

Conversation

Ikamrava
Copy link

This is a:

  • New feature - new behaviour has been implemented
  • 🐛 Bug fix - existing behaviour has been made to behave
  • ♻️ Refactor - the behaviour has not changed, just the implementation
  • Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
  • ⚙️ Chore - maintenance task, behaviour and implementation haven't changed

Description

Currently, if an admin user wants to publish a new resource they have to suggest it on the /suggest page and then publish it on the /drafts page. Given that they have sufficient permissions to publish the resource, it would be more efficient if their resource was published as soon as they suggest it.

  • Purpose - An admin's suggested resource will be published immediately upon submission.
  • How to check - Log in as and Admin user then click on suggestion. You should be able to see this :

1

Fill out the form and click Suggest. You should be able to publish a resource.

2

You can make sure by going back to the home page and seeing your resource and you should not see your suggestion on the draft page

3

Log out and log in as a normal user. When you go to the suggestion page, it should be like this:

4

Fill out the form and click Suggest. You should be able to make a suggestion and see this :

5

You can log out and log in as an admin, and you should be able to see a draft waiting to be published.

6

Links

Link to the Backlog

Author checklist

  • I have written a title that reflects the relevant ticket
  • I have written a description that says what the PR does and how to validate it
  • I have linked to the project board ticket (and any related PRs/issues) in the Links section
  • I have added a link to this PR to the ticket
  • I have made the PR to main from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
  • I have manually tested that the app still works correctly
  • I have requested reviewers here and in my team chat channel
  • I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
  • I have added tests, or new tests were not required
  • I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

Copy link

🍞 Closing as stale (more than one month without updates)

@github-actions github-actions bot closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant