Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign topics to resources #9

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Assign topics to resources #9

merged 8 commits into from
Jul 31, 2023

Conversation

textbook
Copy link
Member

@textbook textbook commented Jul 31, 2023

This is a:

  • New feature - new behaviour has been implemented
  • 🐛 Bug fix - existing behaviour has been made to behave
  • ♻️ Refactor - the behaviour has not changed, just the implementation
  • Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
  • ⚙️ Chore - maintenance task, behaviour and implementation haven't changed

Description

  • Purpose - allows resources to be allocated to specific topics (e.g. "JavaScript" or "HTML/CSS") to help the user determine what's interesting to them.
  • How to check -
    • Check out the branch

    • Run npm run migration -- up to apply the migration

      • Run npm run migration -- down 1 to check the migration can be reversed, then -- up again
    • Log in and visit the "Suggest" page

    • There should be a new "Topic" field, with a drop-down menu to select a topic:

      Screenshot 2023-07-31 at 11 51 26

    • The topic should be optional (i.e. you can still create a resource without one)

    • If a resource does have a topic, the name of the topic should be shown in the drafts list (when draft) and on the home page (when published):

      Screenshot 2023-07-31 at 11 54 04

    • Review the API docs, /api/topics and /api/resources endpoint descriptions should match the observed behaviour

    • Run npm run migration -- down 1 before switching back to any other branches

Links

  • N/A

Author checklist

  • I have written a title that reflects the relevant ticket
  • I have written a description that says what the PR does and how to validate it
  • I have linked to the project board ticket (and any related PRs/issues) in the Links section
  • I have added a link to this PR to the ticket
  • I have made the PR to main from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
  • I have manually tested that the app still works correctly
  • I have requested reviewers here and in my team chat channel
  • I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
  • I have added tests, or new tests were not required
  • I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

@textbook textbook merged commit 2ffbff5 into main Jul 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant