New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: right-click menu problem on windows, focus change parent scrollTop #4

Open

z-ZYS-s wants to merge 1 commit into CodeboxIDE:master from z-ZYS-s:master

z-ZYS-s commented Jan 13, 2016

It costs more time to show right-click menu in browsers on windows.
There are some problems when switching copy and paste menus.

Following changes are for these two bugs.

that.element.contentEditable = true;
setTimeout(function() {
    that.element.contentEditable = 'inherit'; // 'false';
    var selection = utils.getSelection();
    // If user doesn't select text
    if (!selection || (Terminal.isMac && selection === ' '))
        that.inputElement.focus();
}, Terminal.isMac ? 1 : 400);

There is a bug when window is smaller than a terminal and some parent node of this terminal like can be scrolled. If you scroll in the bottom and then click the terminal, it will jump to the top. This is because .terminal-input textarea focused is on the top.

-    position: absolute;
-    top: 0;
+    position: fixed;

All bugs have been tested in our product.


          Fix: right-click menu problem on windows, focus change parent scrollTop

3345f49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet