-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created new React Native Components entry #1269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsonrd, I did a first review and left some comments.
I also want to ask @Dusch4593 how we feel about the off-site links to code.
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
Got it. Will be checking and solving all these. Also let me know about the off-site links and I'll fix it if neccessary. Thanks for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsonrd One more change before passing on to a second review: Go through the file and make sure there are line breaks before and after headers and code blocks.
Understood. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsonrd, looks ready for a second review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsonrd Left some comments/suggestions for you for the second review. 😄
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/react-native-components/react-native-components.md
Outdated
Show resolved
Hide resolved
@ericsonrd apologies for any confusion! I mistakenly pushed up some changes but see that you're still working on getting the changes up. |
…name and directory
Hey @yangc95, @Dusch4593. Added the latest changes to this entry. In the first pharagraph I modified the first description of Components, because it would read "Components are components...", then in the table instead of changing "React Native Components" to "Native Components", changed it to "Core Components" to match the classification on the React Native documentation. Let me know if it's ok or it would need changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsonrd I had a few suggestions/comments to add 🙂
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsonrd Just some last points of feedback from me. Mostly to do with spacing in the code snippets. 😄
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
@Dusch4593 Done. 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericsonrd Just one last suggestion from me, but looks good otherwise! 😄
Is there anything left to add, change, or check @yangc95?
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
content/react/concepts/react-native/terms/components/components.md
Outdated
Show resolved
Hide resolved
"Update branch with latests commits"
👋 @ericsonrd |
Hurray!! 🎉👏🏼👏🏼 Thanks for all your support and patience @Dusch4593 and @yangc95 helping me navigate the "entanglement", I've sure learned a bit about how to manage it better. And glad to have contributed to Codecademy docs! Be well. |
@ericsonrd Thanks for your consistent efforts! Would you also be able to open a PR for a small change? It looks like some images weren't rendered and need to be replaced with a link that has this format: https://raw.githubusercontent.com/Codecademy/docs/main/media/`filename` In addition, you're currently a private contributor so you're anonymous on this entry. |
Done @yangc95 and @Dusch4593. PR Link: #1466 (comment) |
@ericsonrd Merged! Thanks for making that change ^^ |
Description
New entry about React Native Components for the React Native section in the React topic. It gives clear explanation of React Native components, how they relate to React and what they do to generate fast, native-like UI performance.
Type of Change
Checklist
main
branch.