Created new React Native Components entry #1269

ericsonrd · 2022-11-20T00:44:02Z

Description

New entry about React Native Components for the React Native section in the React topic. It gives clear explanation of React Native components, how they relate to React and what they do to generate fast, native-like UI performance.

Type of Change

Adding a new entry
Updating the documentation

Checklist

All writings are my own.
My entry follows the Codecademy Docs style guide.
My changes generate no new warnings.
I have performed a self-review of my own writing and code.
I have checked my entry and corrected any misspellings.
I have made corresponding changes to the documentation if needed.
I have confirmed my changes are not being pushed from my forked main branch.
I have confirmed that I'm pushing from a new branch named after the changes I'm making.
Under "Development" on the right, I have linked any issues that are relevant to this PR (write "Closes # in the "Description" above).

CLAassistant · 2022-11-20T00:44:07Z

All committers have signed the CLA.

SSwiniarski

@ericsonrd, I did a first review and left some comments.

I also want to ask @Dusch4593 how we feel about the off-site links to code.

content/react/concepts/react-native/react-native-components/react-native-components.md

ericsonrd · 2022-11-21T04:42:59Z

@ericsonrd, I did a first review and left some comments.

I also want to ask @Dusch4593 how we feel about the off-site links to code.

Got it. Will be checking and solving all these. Also let me know about the off-site links and I'll fix it if neccessary. Thanks for your review.

SSwiniarski

@ericsonrd One more change before passing on to a second review: Go through the file and make sure there are line breaks before and after headers and code blocks.

ericsonrd · 2022-11-22T16:38:11Z

@ericsonrd One more change before passing on to a second review: Go through the file and make sure there are line breaks before and after headers and code blocks.

Understood.

SSwiniarski

@ericsonrd, looks ready for a second review.

Dusch4593

@ericsonrd Left some comments/suggestions for you for the second review. 😄

content/react/concepts/react-native/react-native-components/react-native-components.md

yangc95 · 2022-12-29T05:01:47Z

@ericsonrd apologies for any confusion! I mistakenly pushed up some changes but see that you're still working on getting the changes up.

Update branch

…name and directory

ericsonrd · 2023-01-04T19:25:52Z

@ericsonrd apologies for any confusion! I mistakenly pushed up some changes but see that you're still working on getting the changes up.

Hey @yangc95, @Dusch4593. Added the latest changes to this entry. In the first pharagraph I modified the first description of Components, because it would read "Components are components...", then in the table instead of changing "React Native Components" to "Native Components", changed it to "Core Components" to match the classification on the React Native documentation.

Let me know if it's ok or it would need changes.

yangc95

@ericsonrd I had a few suggestions/comments to add 🙂

content/react/concepts/react-native/terms/components/components.md

Dusch4593

@ericsonrd Just some last points of feedback from me. Mostly to do with spacing in the code snippets. 😄

content/react/concepts/react-native/terms/components/components.md

ericsonrd · 2023-01-05T03:50:48Z

@ericsonrd Just some last points of feedback from me. Mostly to do with spacing in the code snippets. 😄

@Dusch4593 Done. 👍🏽

Dusch4593

@ericsonrd Just one last suggestion from me, but looks good otherwise! 😄

Is there anything left to add, change, or check @yangc95?

content/react/concepts/react-native/terms/components/components.md

"Update branch with latests commits"

github-actions · 2023-01-05T18:00:23Z

👋 @ericsonrd
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

ericsonrd · 2023-01-06T04:57:38Z

Hurray!! 🎉👏🏼👏🏼

Thanks for all your support and patience @Dusch4593 and @yangc95 helping me navigate the "entanglement", I've sure learned a bit about how to manage it better. And glad to have contributed to Codecademy docs!

Be well.

yangc95 · 2023-01-06T14:58:04Z

@ericsonrd Thanks for your consistent efforts!

Would you also be able to open a PR for a small change? It looks like some images weren't rendered and need to be replaced with a link that has this format: https://raw.githubusercontent.com/Codecademy/docs/main/media/`filename`

In addition, you're currently a private contributor so you're anonymous on this entry.
If you'd like to make yourself public, add your GitHub account to your Codecademy profile and sign back in with GitHub!

cc: @Dusch4593 @SSwiniarski

ericsonrd · 2023-01-07T00:34:32Z

Done @yangc95 and @Dusch4593.

PR Link: #1466 (comment)

yangc95 · 2023-01-07T15:04:11Z

@ericsonrd Merged! Thanks for making that change ^^

Created new React Native Components entry

ace6d21

ericsonrd added 2 commits November 19, 2022 20:44

Merge branch 'main' into rn_components

d7c1b5e

Update Code Block to language specific syntax

0b18ab3

SSwiniarski added react React entries new entry New entry or entries labels Nov 20, 2022

Merge branch 'main' into rn_components

423864d

SSwiniarski suggested changes Nov 20, 2022

View reviewed changes

SSwiniarski added status: review 1️⃣ completed status: waiting for author labels Nov 20, 2022

SSwiniarski self-assigned this Nov 20, 2022

ericsonrd added 2 commits November 21, 2022 23:15

Merge branch 'main' into rn_components

7698965

Update react-native-components.md

7701566

ericsonrd requested a review from SSwiniarski November 22, 2022 15:41

SSwiniarski suggested changes Nov 22, 2022

View reviewed changes

Update react-native-components.md

5325386

ericsonrd requested a review from SSwiniarski November 26, 2022 04:12

SSwiniarski approved these changes Nov 26, 2022

View reviewed changes

SSwiniarski removed the status: waiting for author label Nov 26, 2022

Dusch4593 self-assigned this Dec 10, 2022

Dusch4593 added the status: under review Issue or PR is currently being reviewed label Dec 10, 2022

Dusch4593 suggested changes Dec 10, 2022

View reviewed changes

Dusch4593 added status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Dec 10, 2022

Merge branch 'Codecademy:main' into rn_components

79a1e8d

yangc95 added the status: review 2️⃣ completed label Dec 22, 2022

Merge branch 'Codecademy:main' into rn_components

a029174

ericsonrd added 2 commits January 4, 2023 13:14

Merge remote-tracking branch 'origin/main' into rn_components

db11768

Update branch

Updated React Native Components entry with corrections and change of …

810e9ad

…name and directory

yangc95 reviewed Jan 4, 2023

View reviewed changes

yangc95 added the status: review 3️⃣ completed label Jan 4, 2023

Performed latest suggestions on Components entry

4482a93

Dusch4593 suggested changes Jan 5, 2023

View reviewed changes

Dusch4593 assigned yangc95 Jan 5, 2023

Performed new sugggestions on code snippets

1c60c07

Dusch4593 approved these changes Jan 5, 2023

View reviewed changes

content/react/concepts/react-native/terms/components/components.md Outdated Show resolved Hide resolved

yangc95 reviewed Jan 5, 2023

View reviewed changes

content/react/concepts/react-native/terms/components/components.md Outdated Show resolved Hide resolved

Performed latest suggestions on code snippets

6836e33

yangc95 approved these changes Jan 5, 2023

View reviewed changes

yangc95 removed the status: waiting for author label Jan 5, 2023

ericsonrd and others added 2 commits January 5, 2023 13:21

Merge remote-tracking branch 'origin/main' into rn_components

1264bb6

"Update branch with latests commits"

Run scripts

0f6a793

yangc95 merged commit cc5b027 into Codecademy:main Jan 5, 2023

ericsonrd deleted the rn_components branch January 7, 2023 00:00

ericsonrd restored the rn_components branch January 7, 2023 00:01

ericsonrd deleted the rn_components branch January 7, 2023 00:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created new React Native Components entry #1269

Created new React Native Components entry #1269

ericsonrd commented Nov 20, 2022 •

edited

Loading

CLAassistant commented Nov 20, 2022 •

edited

Loading

SSwiniarski left a comment

ericsonrd commented Nov 21, 2022

SSwiniarski left a comment •

edited

Loading

ericsonrd commented Nov 22, 2022 •

edited

Loading

SSwiniarski left a comment

Dusch4593 left a comment

yangc95 commented Dec 29, 2022

ericsonrd commented Jan 4, 2023

yangc95 left a comment

Dusch4593 left a comment

ericsonrd commented Jan 5, 2023

Dusch4593 left a comment

github-actions bot commented Jan 5, 2023

ericsonrd commented Jan 6, 2023

yangc95 commented Jan 6, 2023

ericsonrd commented Jan 7, 2023

yangc95 commented Jan 7, 2023

Created new React Native Components entry #1269

Created new React Native Components entry #1269

Conversation

ericsonrd commented Nov 20, 2022 • edited Loading

Description

Type of Change

Checklist

CLAassistant commented Nov 20, 2022 • edited Loading

SSwiniarski left a comment

Choose a reason for hiding this comment

ericsonrd commented Nov 21, 2022

SSwiniarski left a comment • edited Loading

Choose a reason for hiding this comment

ericsonrd commented Nov 22, 2022 • edited Loading

SSwiniarski left a comment

Choose a reason for hiding this comment

Dusch4593 left a comment

Choose a reason for hiding this comment

yangc95 commented Dec 29, 2022

ericsonrd commented Jan 4, 2023

yangc95 left a comment

Choose a reason for hiding this comment

Dusch4593 left a comment

Choose a reason for hiding this comment

ericsonrd commented Jan 5, 2023

Dusch4593 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 5, 2023

ericsonrd commented Jan 6, 2023

yangc95 commented Jan 6, 2023

ericsonrd commented Jan 7, 2023

yangc95 commented Jan 7, 2023

ericsonrd commented Nov 20, 2022 •

edited

Loading

CLAassistant commented Nov 20, 2022 •

edited

Loading

SSwiniarski left a comment •

edited

Loading

ericsonrd commented Nov 22, 2022 •

edited

Loading