-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Db::executeQuery() for null parameter #63
Fix Db::executeQuery() for null parameter #63
Conversation
Experiencing the same problem. Downgrading to v3.0.1 helps, but introduces another problem (that is fixed in v3.1.0). |
same here, please merge |
We have the same problem. #48 causes many of our tests to fail as show below. Please merge and ship this fix.
|
Experiencing the same issue! Please merge this fix!
|
Can someone please merge @W0rma's PR? Real companies are relying on this and the fact that a fix is present for 5 days and it's just waiting to be merged is quite sad. |
Please merge |
the quickly solution is, |
Merge this, suggestion to use |
@Naktibalda or @sergeyklay can you check this one? |
Just to point out, this issue was introduced on add it in your composer.json, and after it pass, you just need to remove it from conflict. "conflict": {
"codeception/module-db": ">3.1.0"
},
|
I know, but ironically, in version 3.1.1, there is a fix for the UTF-8 bug #47, which unfortunately affects me too. |
Thank you for the patch and I'm sorry for the delay. |
Seems like #48 broke the following code
After updating
codeception/module-db
from3.1.0
to3.1.1
I get the following error:This PR should fix that by using
PDO::PARAM_NULL
ifnull
was provided in the criteria.Fixes #64