Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against PHP 8.4 #77

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Test against PHP 8.4 #77

wants to merge 3 commits into from

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Dec 6, 2024

Usage of the E_STRICT constant is removed because it is deprecated in PHP 8.4: https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant

@W0rma W0rma marked this pull request as ready for review December 6, 2024 08:03
@W0rma
Copy link
Contributor Author

W0rma commented Dec 6, 2024

Tests are currently red because the MSSQL container could not be started.

@W0rma W0rma mentioned this pull request Dec 6, 2024
@W0rma
Copy link
Contributor Author

W0rma commented Dec 6, 2024

Tests are currently red because the MSSQL container could not be started.

Thanks to the help of @iliayatsenko in #75 (comment) I was able to fix initializing the containers in the CI.

Unfortunately, the next step fails with the following message:

Run /opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P 'P@ssw0rd' -No -Q 'CREATE DATABASE codeception_test' /home/runner/work/_temp/6081b1bb-d085-[4](https://github.com/Codeception/module-db/actions/runs/12197216359/job/34026394768#step:3:5)246-b0c0-762bc15f44d6.sh: line 1: /opt/mssql-tools18/bin/sqlcmd: No such file or directory

I'm a bit confused because /opt/mssql-tools18/bin/sqlcmd seemed to work fine in the step before.
Could this be some kind of caching issue?

@iliayatsenko
Copy link

@W0rma , possibly it is because this command is run in ubuntu container, not in mcr.microsoft.com/mssql/server?
But another problem is that for this command to work there should be mssql installed in ubuntu container. And I do not see where is it being installed.

@szhajdu , could you please assist with CI script? Also, looks like it does not run automatically on PRs? How to trigger it in my PR?

@szhajdu
Copy link
Collaborator

szhajdu commented Dec 12, 2024

The mssql image has been built for Linux platforms. You can try downgrading, as they may have introduced breaking changes in the latest releases. I’ll also take a look in the coming days.

@szhajdu
Copy link
Collaborator

szhajdu commented Dec 12, 2024

@iliayatsenko, let's replace the MSSQL image in #75. After it is merged, the changes can be pulled into this branch as well, which will resolve the red pipeline for @W0rma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants