-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against PHP 8.4 #77
base: master
Are you sure you want to change the base?
Conversation
Tests are currently red because the MSSQL container could not be started. |
Thanks to the help of @iliayatsenko in #75 (comment) I was able to fix initializing the containers in the CI. Unfortunately, the next step fails with the following message:
I'm a bit confused because |
@W0rma , possibly it is because this command is run in ubuntu container, not in mcr.microsoft.com/mssql/server? @szhajdu , could you please assist with CI script? Also, looks like it does not run automatically on PRs? How to trigger it in my PR? |
The mssql image has been built for Linux platforms. You can try downgrading, as they may have introduced breaking changes in the latest releases. I’ll also take a look in the coming days. |
@iliayatsenko, let's replace the MSSQL image in #75. After it is merged, the changes can be pulled into this branch as well, which will resolve the red pipeline for @W0rma. |
Usage of the
E_STRICT
constant is removed because it is deprecated in PHP 8.4: https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant