Pre-calculate battery stats based on GivTCP UoM attribute #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21 - the card did not previously take into account the configurable
unit_of_measurement
attribute available in the GivTCP entities. This PR fixes the issue, in addition to refactoring the code to pre-calculate all statistics during render time in a single object. Thanks to @gcoan for reporting the issue.GivTcpBatteryStats
typesetRawValues
method to grab GivTCP data at render timeunit_of_measurement
value if available