-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/block chart edit #1136
Feat/block chart edit #1136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor remarks on the names of some variables; otherwise, it is a very solid work in bringing the library experience into the editor.
@preda-bogdan Tested and found a single issue:
Can be checked here:
|
@preda-bogdan you can add: window.send_to_editor = () => {
view.close();
}; I found the same issue yesterday. |
@Soare-Robert-Daniel thank you, but we also need to notify the editor to re-render the block. |
@irinelenache The chart should update upon the window closing and no error should be displayed in the console. Let me know if everything is working as expected now. Thank you! |
@preda-bogdan The issue is fixed now, thank you 🚀 |
Summary
Added a button inside Gutenberg to Edit the Chart from a single location. Will open a Media pop-up Modal, the same that is used outside of the editor.
Added a new filter
visualizer_legacy_block_edit
to allow users to switch to the legacy behavior. Eg.Hide previous controls from the block.
Added E2E test.
Will affect the visual aspect of the product
YES
Screenshots
Edit Chart
Media Pop-up
Test instructions
Check before Pull Request is ready:
Closes Codeinwp/visualizer-pro#440.