build: added renew/activate license notice #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirate-bot
added
the
pr-checklist-incomplete
GrigoreMihai
added
the
pr-checklist-skip
pirate-bot
added
pr-checklist-complete
Comment on lines
346
to
348
| if ( ! empty( $chart_type ) && isset( $types[ $chart_type ] ) ) { | ||
| $pro_class = 'is_pro'; | ||
| } |
There was a problem hiding this comment.
for the CSS class, I recommend viz-is-pro-chart. is_pro is not recommended, and is-pro might be too generic, and we can have unwanted surprises from other plugins.
Soare-Robert-Daniel
approved these changes
May 11, 2024
|
@GrigoreMihai Tested and everything's fine here 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the notice as in the issue. Added a new variable to the chart display page to check if the user is pro or not.
Will affect visual aspect of the product
YES
Screenshots
https://vertis.d.pr/i/FcrgAN
Test instructions
Check the issue for details.
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/434.