Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binary mode for HTTP responses #7

Open
garie opened this issue May 18, 2017 · 2 comments
Open

Support binary mode for HTTP responses #7

garie opened this issue May 18, 2017 · 2 comments

Comments

@garie
Copy link

garie commented May 18, 2017

Mountebank 1.10.0 supports binary responses: http://www.mbtest.org/docs/protocols/http

garie pushed a commit to garie/mountebank-gem that referenced this issue May 18, 2017
Support binary mode.
garie pushed a commit to garie/mountebank-gem that referenced this issue May 18, 2017
Make arguments named.
@miccheng
Copy link
Member

@garie So i have merged the 2 branches you referenced. Look forward to your new pull request. 🙇

garie pushed a commit to garie/mountebank-gem that referenced this issue May 19, 2017
Undo change for named arguments because it isn't working the way I want.
garie pushed a commit to garie/mountebank-gem that referenced this issue May 19, 2017
Verify mode is a valid option.
@garie
Copy link
Author

garie commented May 19, 2017

Thanks! It is definitely working in that it's setting the mode correctly on the mountebank responses, but I haven't actually got it working yet with binary data and I'm not sure why. I posted in the google group for mountebank (https://groups.google.com/forum/#!topic/mountebank-discuss/GpM80zBk86o) and will probably put in a PR as soon as I can figure out what I'm doing wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants